This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Repository navigation
Fixed local errors in .NET Core 2.1 unit tests - #3365
Merged
1 commit merged intoJun 26, 2020
Merged
1 commit merged into
1 commit merged into
Conversation
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Member
|
@Kyaa-dost can you check this out and run the tests locally on your box as well? |
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
4 of 5 tasks
Kyaa-dost
approved these changes
Jun 25, 2020
Kyaa-dost
left a comment
Contributor
There was a problem hiding this comment.
This is ready to 🚀 🚀 Thanks @Sergio0694 !!
Member
Author
|
Happy to help, thank you for trying this out @Kyaa-dost! 😊 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some .NET Core 2.1 unit tests for the base package fail when run locally.
What is the new behavior?
All tests run correctly when executed locally.
PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates